Bug 255864 - [GTK] MiniBrowser: pressing ESC doesn't exit pointer lock mode
Summary: [GTK] MiniBrowser: pressing ESC doesn't exit pointer lock mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-04-24 05:20 PDT by Carlos Garcia Campos
Modified: 2023-04-24 06:28 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-04-24 05:20:30 PDT 
This is because we have an accelerator to stop loading when ESC is pressed, but it's always enabled. The key press is always consumed by the accel and never passed to the view.
Comment 1 Carlos Garcia Campos 2023-04-24 05:25:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13098
Comment 2 EWS 2023-04-24 06:28:30 PDT 
Committed 263308@main (ba351310fb37): <https://commits.webkit.org/263308@main>

Reviewed commits have been landed. Closing PR #13098 and removing active labels.