When watching a video on youtube.com, the following line is printed: `** (WebKitWebProcess:2): WARNING **: 16:18:40.081: WebKit wasn't able to find the DMABuf video sink dependencies. Hardware-accelerated zero-copy video rendering won't be achievable with this plugin.` CPU usage is through the roof.
This can be observed on Epiphany Technology Preview 44.0-39-g93250d36f+/ WebKitGTK 2.41.3
This cannot be observed on Gnome Web 44.2/ WebKitGTK 2.40.1
Your runtime doesn't ship GStreamer 1.22 I guess. You can check by loading webkit://gpu The sink is disabled for older versions. I might work for older versions, or it might not. It's untested. bool webKitDMABufVideoSinkProbePlatform() { return webkitGstCheckVersion(1, 22, 0) && isGStreamerPluginAvailable("app"); }
If it doesn't work for GStreamer 1.20.x perhaps DMABUF sink could be disabled there.
Who said it doesn´t?
Can confirm: this message does not appear with WEBKIT_GST_DMABUF_SINK_ENABLED=1 in Tech Preview
Probably should not print the error message if GStreamer version is less than 1.22?
(In reply to kdwkleung from comment #6) > Can confirm: this message does not appear with > WEBKIT_GST_DMABUF_SINK_ENABLED=1 in Tech Preview I'm confused now. WEBKIT_GST_DMABUF_SINK_ENABLED was afaik replaced by WEBKIT_GST_DMABUF_SINK_DISABLED in 2.41. To sum-up, again, the sink is opt-in in versions < 2.40 and opt-out in > 2.40.
Oh now that I test it again the message shows up even with WEBKIT_GST_DMABUF_SINK_ENABLED=1 on Tech Preview.
(In reply to kdwkleung from comment #9) > Oh now that I test it again the message shows up even with > WEBKIT_GST_DMABUF_SINK_ENABLED=1 on Tech Preview. That env var is not used by 2.41, in case it wasn't clear from previous comments.
Pull request: https://github.com/WebKit/WebKit/pull/13240
Committed 263459@main (4c8196fde7da): <https://commits.webkit.org/263459@main> Reviewed commits have been landed. Closing PR #13240 and removing active labels.