Bug 255928 - Simplify / optimize JSC's LiteralParser
Summary: Simplify / optimize JSC's LiteralParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-25 08:50 PDT by Chris Dumez
Modified: 2023-04-26 08:57 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-04-25 08:50:04 PDT 
Simplify / optimize JSC's LiteralParser:
- Avoid storing the start/end pointers inside LiteralParserToken, as they are not actually needed. We already have a `stringStart + length` for strings/identifiers, which is all that's needed.
- Stop using LiteralParserToken::stringIs8Bit for identifiers. Unlike strings, identifiers always use the same character type as the LiteralParser. This also avoids some unnecessary branching.
Comment 1 Chris Dumez 2023-04-25 08:52:57 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13151
Comment 2 EWS 2023-04-26 08:56:22 PDT 
Committed 263416@main (f6ec77d6554e): <https://commits.webkit.org/263416@main>

Reviewed commits have been landed. Closing PR #13151 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-04-26 08:57:21 PDT 
<rdar://problem/108559160>