Bug 255932 - [GLib] Lobotomize FileSystemGlib.cpp
Summary: [GLib] Lobotomize FileSystemGlib.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-25 09:50 PDT by Michael Catanzaro
Modified: 2023-04-28 07:45 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-04-25 09:50:06 PDT 
Most of FileSystemGlib.cpp is redundant with FileSystemPOSIX.cpp. There is no good reason to implement the POSIX-style WTF::Filesystem APIs using GIO when we have access to POSIX. FileSystemGlib.cpp is now going to rather extreme lengths to work around impedance between the GIO and POSIX APIs, and it's much simpler to just use POSIX.
Comment 1 Michael Catanzaro 2023-04-25 09:51:19 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13153
Comment 2 EWS 2023-04-28 07:45:16 PDT 
Committed 263503@main (448487f4e635): <https://commits.webkit.org/263503@main>

Reviewed commits have been landed. Closing PR #13153 and removing active labels.