Bug 255992 - Use smart pointers for captured variables in NetworkProcess::initializeNetworkProcess
Summary: Use smart pointers for captured variables in NetworkProcess::initializeNetwor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JC Alvarado
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-26 09:57 PDT by JC Alvarado
Modified: 2023-04-27 12:50 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JC Alvarado 2023-04-26 09:57:06 PDT 
We capture a variable in NetworkProcess::initializeNetworkProcess and store it in a separate object. We should protect this variable using smart pointers.
Comment 1 Radar WebKit Bug Importer 2023-04-26 09:57:24 PDT 
<rdar://problem/108561984>
Comment 2 JC Alvarado 2023-04-26 10:21:59 PDT 
There is similar code in GPUProcess::initializeGPUProcess that where we should also use a smart pointer
Comment 3 JC Alvarado 2023-04-26 11:10:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13202
Comment 4 EWS 2023-04-27 12:50:39 PDT 
Committed 263466@main (5f072a498756): <https://commits.webkit.org/263466@main>

Reviewed commits have been landed. Closing PR #13202 and removing active labels.