Bug 256025 - [pre-push] Check publish pushes for references to redacted commits
Summary: [pre-push] Check publish pushes for references to redacted commits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-26 20:39 PDT by Jonathan Bedard
Modified: 2023-05-04 09:26 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-04-26 20:39:27 PDT
A publication push will disable checks for commit membership in a more secure remote. We still should check if commits contain redacted commits, though. This is a potentially expensive operation, and means we need to check more commits by default (because we are checking more than just completely novel commits not belonging to any remote).
Comment 1 Radar WebKit Bug Importer 2023-04-26 20:39:42 PDT
<rdar://problem/108588596>
Comment 2 Jonathan Bedard 2023-04-27 13:32:40 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13246
Comment 3 EWS 2023-05-04 09:26:21 PDT
Committed 263677@main (f4a0a73081dd): <https://commits.webkit.org/263677@main>

Reviewed commits have been landed. Closing PR #13246 and removing active labels.