Bug 256034 - Some FontSizeAdjust members are uninitialized
Summary: Some FontSizeAdjust members are uninitialized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-27 02:30 PDT by Vitaly Dyackhov
Modified: 2023-05-18 02:18 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Dyackhov 2023-04-27 02:30:05 PDT
While this is not a problem for element styles, since they always assign initial values during the resolving process, it is for the document style. The document style gets some properties initialized in `RenderStyle resolveForDocument(const Document& document)` but not `fontSizeAdjust`, thus potentially leaving them to random values. It means that two otherwise identical document styles will be considered different and cause style invalidation of the entire DOM tree when it's not really necessary.
Comment 1 Vitaly Dyackhov 2023-04-27 02:43:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13230
Comment 2 Radar WebKit Bug Importer 2023-05-04 02:31:19 PDT
<rdar://problem/108883885>
Comment 3 EWS 2023-05-18 02:18:13 PDT
Committed 264195@main (493fe8cbc12c): <https://commits.webkit.org/264195@main>

Reviewed commits have been landed. Closing PR #13230 and removing active labels.