Bug 256043 - [WPE] run-minibrowser: don't set a platform when COG_PLATFORM_NAME is on the env
Summary: [WPE] run-minibrowser: don't set a platform when COG_PLATFORM_NAME is on the env
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks: 249031
  Show dependency tree / graph
 
Reported: 2023-04-27 08:09 PDT by Carlos Alberto Lopez Perez
Modified: 2023-04-27 11:40 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2023-04-27 08:09:02 PDT 
On https://github.com/Igalia/cog/pull/561 Cog was patched to allow specifying a platform plugin name via the env variable COG_PLATFORM_NAME

So the run-minibrowser script should check for this env var case when deciding which Cog platform plugin to select to avoid an override.
Comment 1 Carlos Alberto Lopez Perez 2023-04-27 08:25:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13237
Comment 2 EWS 2023-04-27 11:40:42 PDT 
Committed 263463@main (f081085077e6): <https://commits.webkit.org/263463@main>

Reviewed commits have been landed. Closing PR #13237 and removing active labels.