Bug 256048 - Adopt smart pointer for captured variables in VideoTrackPrivateAVFObjC constructor
Summary: Adopt smart pointer for captured variables in VideoTrackPrivateAVFObjC constr...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JC Alvarado
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-27 10:50 PDT by JC Alvarado
Modified: 2023-04-27 11:02 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JC Alvarado 2023-04-27 10:50:01 PDT 
In the constructor for VideoTrackPrivateAVFObjC we captured a reference to self in a lambda and then store in a separate object. We should adopt smart pointers in that lambda to avoid lifetime issues.
Comment 1 Radar WebKit Bug Importer 2023-04-27 11:01:16 PDT 
<rdar://problem/108617701>
Comment 2 JC Alvarado 2023-04-27 11:02:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13241