Bug 256097 - [ macOS ] TestWebKitAPI.WebKitLegacy.MediaPlaybackSleepAssertion is a constant failure
Summary: [ macOS ] TestWebKitAPI.WebKitLegacy.MediaPlaybackSleepAssertion is a constan...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-28 10:35 PDT by Robert Jenner
Modified: 2023-04-28 15:01 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2023-04-28 10:35:30 PDT 
TestWebKitAPI.WebKitLegacy.MediaPlaybackSleepAssertion

is a constant failure on macOS.

HISTORY:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKitLegacy.MediaPlaybackSleepAssertion

FAIL TEXT:
    TestWebKitAPI.WebKitLegacy.MediaPlaybackSleepAssertion
        2023-04-28 09:49:50.584 TestWebKitAPI[69683:178359483] *** WARNING: Method convertPointToBase: in class NSView is deprecated on 10.7 and later. It should not be used in new applications. 
        
        /Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:179
        Value of: hasAssertionType(CFSTR("PreventUserIdleDisplaySleep"))
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/Apple-Ventura-Release-Build/build/Tools/TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:186
        Value of: hasAssertionType(CFSTR("PreventUserIdleSystemSleep"))
          Actual: false
        Expected: true
Comment 1 Radar WebKit Bug Importer 2023-04-28 10:35:50 PDT 
<rdar://problem/108666759>
Comment 2 Robert Jenner 2023-04-28 11:17:57 PDT 
I was able to reproduce the failure, as well as bisect to a regression point. You can reproduce at Ventura Release ToT running as follows:

run-api-tests TestWebKitAPI.WebKitLegacy.MediaPlaybackSleepAssertion

And I was able to reproduce the failure back to 263474@main, but not at 263473@main. So it appears that https://commits.webkit.org/263474@main is where this test regressed at.
Comment 3 Chris Dumez 2023-04-28 12:55:58 PDT 
Will fix shortly.
Comment 4 Chris Dumez 2023-04-28 13:04:56 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13285
Comment 5 EWS 2023-04-28 15:01:42 PDT 
Committed 263518@main (e90882bc5116): <https://commits.webkit.org/263518@main>

Reviewed commits have been landed. Closing PR #13285 and removing active labels.