Bug 256164 - UBSan: Source/WTF/wtf/text/IntegerToStringConversion.h does not fit in an IntegerType
Summary: UBSan: Source/WTF/wtf/text/IntegerToStringConversion.h does not fit in an Int...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 167087
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-01 08:21 PDT by Seija K.
Modified: 2023-05-09 13:30 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seija K. 2023-05-01 08:21:04 PDT 
Although we check that integer is less than 0 before negating it, the
UBSanitizer keeps tripping up at this section. The proper fix would be
to use std::make_unsigned_t<IntegerType> here, to convert the variable
to its unsigned equivalent.
Comment 1 Seija K. 2023-05-01 08:23:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13308
Comment 2 Radar WebKit Bug Importer 2023-05-08 08:22:17 PDT 
<rdar://problem/109040652>
Comment 3 EWS 2023-05-09 08:56:25 PDT 
Committed 263866@main (a83ee572364b): <https://commits.webkit.org/263866@main>

Reviewed commits have been landed. Closing PR #13308 and removing active labels.