Bug 256268 - [LFC][Floating] LineBuilder shouldn't mutate float box geometry
Summary: [LFC][Floating] LineBuilder shouldn't mutate float box geometry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-03 12:28 PDT by zalan
Modified: 2023-05-04 19:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.32 KB, patch)
2023-05-03 12:42 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.76 KB, patch)
2023-05-03 15:34 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.76 KB, patch)
2023-05-04 13:53 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (17.18 KB, patch)
2023-05-04 17:27 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-05-03 12:28:53 PDT 
but instead just return the list of placed floats.
Comment 1 zalan 2023-05-03 12:42:34 PDT 
Created attachment 466197 [details]
Patch
Comment 2 zalan 2023-05-03 15:34:51 PDT 
Created attachment 466198 [details]
Patch
Comment 3 Antti Koivisto 2023-05-04 08:44:22 PDT 
Comment on attachment 466198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466198&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:433
> +        for (auto floatItem : intrinsicContent.placedFloats)

why copy?
Comment 4 zalan 2023-05-04 13:53:50 PDT 
Created attachment 466212 [details]
Patch
Comment 5 zalan 2023-05-04 13:56:30 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 466198 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466198&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:433
> > +        for (auto floatItem : intrinsicContent.placedFloats)
> 
> why copy?
indeed.
Comment 6 zalan 2023-05-04 17:27:44 PDT 
Created attachment 466216 [details]
[fast-cq]Patch
Comment 7 EWS 2023-05-04 19:10:37 PDT 
Committed 263704@main (6329f3456d6a): <https://commits.webkit.org/263704@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466216 [details].
Comment 8 Radar WebKit Bug Importer 2023-05-04 19:11:19 PDT 
<rdar://problem/108927449>