Bug 256318 - [GPU Process][Filters] Make FilterFunction a RenderingResource
Summary: [GPU Process][Filters] Make FilterFunction a RenderingResource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 232845
  Show dependency tree / graph
 
Reported: 2023-05-04 10:19 PDT by Said Abou-Hallawa
Modified: 2023-05-08 13:42 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-05-04 10:19:19 PDT 
This will allow caching the SVGFilter in GPU Process and will allow referencing it in DisplayList items by its RenderingResourceIdentifier. To do that RenderingResource has to not be a RefCounted. SVGFilter inherits FilterFunction which is a RefCounted. NativeImage, Gradient, DecomposeGlyphs and SVGFilter have to handle the ref-counted separate from RenderingResource.
Comment 1 Radar WebKit Bug Importer 2023-05-04 10:29:26 PDT 
<rdar://problem/108900138>
Comment 2 Said Abou-Hallawa 2023-05-04 10:33:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13446
Comment 3 EWS 2023-05-08 13:42:07 PDT 
Committed 263820@main (9a8998b85a0a): <https://commits.webkit.org/263820@main>

Reviewed commits have been landed. Closing PR #13446 and removing active labels.