256323 – [image-set] `type()` function should only take one string

Bug 256323 - [image-set] `type()` function should only take one string

Summary: [image-set] `type()` function should only take one string

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CSS (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Ryan Reno

URL:	https://wpt.fyi/results/css/css-image...
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2023-05-04 11:03 PDT by Tim Nguyen (:ntim)
Modified:	2023-05-21 19:13 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Nguyen (:ntim) 2023-05-04 11:03:52 PDT

...

Comment 1 Radar WebKit Bug Importer 2023-05-04 13:14:11 PDT

<rdar://problem/108909363>

Comment 2 Tim Nguyen (:ntim) 2023-05-04 13:15:13 PDT

To be clear, `type("image/png" "image/png")` should be rejected, this is tested by https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat

Comment 3 Ryan Reno 2023-05-04 21:21:05 PDT

I'm just consuming the whole block when consuming the type function. I'll look for a way to either specify how many arguments to consume or maybe just peek again and make sure it's a close paren token.

Comment 4 Ryan Reno 2023-05-21 14:50:27 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14161

Comment 5 EWS 2023-05-21 19:13:46 PDT

Committed 264310@main (f52fdf6f4c9f): <https://commits.webkit.org/264310@main>

Reviewed commits have been landed. Closing PR #14161 and removing active labels.