Bug 256333 - [GPU Process][Filters] Make SVGFilter own a vector of unique FilterEffects
Summary: [GPU Process][Filters] Make SVGFilter own a vector of unique FilterEffects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 232845
  Show dependency tree / graph
 
Reported: 2023-05-04 13:53 PDT by Said Abou-Hallawa
Modified: 2023-06-01 11:39 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-05-04 13:53:51 PDT 
Currently SVGFilter owns a SVGFilterExpression which is a Vector of SVGFilterExpressionTerm. The SVGFilterExpressionTerm holds a Ref<FilterEffect> which maybe referenced more than once by multiple SVGFilterExpressionTerms.

We need make SVGFilter own a Vector of unique FilterEffects. SVGFilterExpressionTerm will hold an index to this Vector. This will allow building an SVGFilterTransaction which is a set of altered unique FilterEffects identified by the index in the vector of unique FilterEffects of SVGFilter.
Comment 1 Radar WebKit Bug Importer 2023-05-08 14:53:26 PDT 
<rdar://problem/109060794>
Comment 2 Said Abou-Hallawa 2023-05-08 19:10:53 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13619
Comment 3 EWS 2023-05-09 16:51:08 PDT 
Committed 263886@main (56cc7591e5e3): <https://commits.webkit.org/263886@main>

Reviewed commits have been landed. Closing PR #13619 and removing active labels.