Bug 256354 - InViewSizeAdjust LayoutPhase should have ScriptDisallowedScope
Summary: InViewSizeAdjust LayoutPhase should have ScriptDisallowedScope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 256386 256403
Blocks: 256296
  Show dependency tree / graph
 
Reported: 2023-05-04 23:12 PDT by Ryosuke Niwa
Modified: 2023-05-08 18:18 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2023-05-04 23:12:37 PDT 
Deploy ScriptDisallowedScope::InMainThread in LayoutPhase::InViewSizeAdjust.
Comment 1 Ryosuke Niwa 2023-05-04 23:16:02 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13486
Comment 2 Ryosuke Niwa 2023-05-05 01:17:42 PDT 
Hm... we have a problem:

#0  0x00007f84453d299e in WTFCrash () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#1  0x00007f8446ab7cd4 in WebCore::Document::updateLayout() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#2  0x00007f8446ab8662 in WebCore::Document::updateLayoutIgnorePendingStylesheets(WebCore::Document::RunPostLayoutTasks) () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#3  0x00007f844721a42d in WebCore::Page::pageCount() const () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#4  0x00007f8443d53978 in WebKit::WebPage::mainFrameDidLayout() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#5  0x00007f84472054d2 in WebCore::LocalFrameView::performPostLayoutTasks() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#6  0x00007f844720602c in WebCore::LocalFrameViewLayoutContext::runOrScheduleAsynchronousTasks() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#7  0x00007f8447205ab3 in WebCore::LocalFrameViewLayoutContext::performLayout() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#8  0x00007f8447205e19 in WebCore::LocalFrameViewLayoutContext::layout() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#9  0x00007f8447207afc in non-virtual thunk to WebCore::LocalFrameView::updateContentsSize() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#10 0x00007f8447335d57 in WebCore::ScrollView::updateScrollbars(WebCore::IntPoint const&) () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#11 0x00007f8447336054 in WebCore::ScrollView::setContentsSize(WebCore::IntSize const&) () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#12 0x00007f84471fa190 in WebCore::LocalFrameView::setContentsSize(WebCore::IntSize const&) () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#13 0x00007f84471fa41b in WebCore::LocalFrameView::adjustViewSize() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#14 0x00007f8447205d8d in WebCore::LocalFrameViewLayoutContext::performLayout() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
#15 0x00007f8447205e19 in WebCore::LocalFrameViewLayoutContext::layout() () at /app/webkit/WebKitBuild/Release/lib/libWPEWebKit-2.0.so.1
Comment 3 EWS 2023-05-08 18:17:04 PDT 
Committed 263843@main (ecfaca4e0bf4): <https://commits.webkit.org/263843@main>

Reviewed commits have been landed. Closing PR #13486 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-05-08 18:18:20 PDT 
<rdar://problem/109070233>