Bug 256399 - [UI-side compositing] Guard against UI process hangs caused by incorrect frame rate data
Summary: [UI-side compositing] Guard against UI process hangs caused by incorrect fram...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-05 15:02 PDT by Simon Fraser (smfr)
Modified: 2023-05-08 11:18 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-05-05 15:02:56 PDT 
There's some evidence of a UI-process (i.e. Safari) hang caused by RemoteLayerTreeEventDispatcher::waitForRenderingUpdateCompletionOrTimeout() taking too long. This could happen if m_stateCondition.waitUntil() has a long timeout, so impose a cap of 32ms on that timeout.
Comment 1 Simon Fraser (smfr) 2023-05-05 15:03:16 PDT 
<rdar://108954321>
Comment 2 Simon Fraser (smfr) 2023-05-05 15:09:42 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13525
Comment 3 EWS 2023-05-08 11:18:39 PDT 
Committed 263806@main (3f7af1859b92): <https://commits.webkit.org/263806@main>

Reviewed commits have been landed. Closing PR #13525 and removing active labels.