Bug 256439 - REGRESSION (244038@main): toPKShippingMethods() causes leaks by returning retained object unexpectedly
Summary: REGRESSION (244038@main): toPKShippingMethods() causes leaks by returning ret...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 221960
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-07 20:33 PDT by David Kilzer (:ddkilzer)
Modified: 2023-05-08 01:26 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-05-07 20:33:03 PDT 
toPKShippingMethods() causes leaks by returning retained object unexpectedly.

Method is defined in Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm.

Regressed in:

    REGRESSION(r271735): PaymentShippingOption.selected ignored
    <https://bugs.webkit.org/show_bug.cgi?id=221960>
    <rdar://problem/73464404>
    <https://commits.webkit.org/244038@main>
Comment 1 Radar WebKit Bug Importer 2023-05-07 20:33:31 PDT 
<rdar://problem/109023223>
Comment 2 David Kilzer (:ddkilzer) 2023-05-07 20:38:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13560
Comment 3 EWS 2023-05-08 01:26:56 PDT 
Committed 263788@main (fc81fe749d70): <https://commits.webkit.org/263788@main>

Reviewed commits have been landed. Closing PR #13560 and removing active labels.