Hi Team, Web-Spec: https://html.spec.whatwg.org/C/#htmlframesetelement During reviewing, HTMLFrameSetElement.idl file, I noticed following: 1) We are missing constructor: [HTMLConstructor] constructor(); 2) 'onerror' is using EventHandler, while it should be "OnErrorEventHandler": https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLFrameSetElement.idl#28 ____ This might be resulting us failing following WPT Tests: https://wpt.fyi/results/html/webappapis/scripting/events/event-handler-processing-algorithm-error/frameset-element-synthetic-errorevent.html?label=master&label=experimental&aligned&q=frameset Live Link - http://wpt.live/html/webappapis/scripting/events/event-handler-processing-algorithm-error/frameset-element-synthetic-errorevent.html Just wanted to raise so we can fix this. Thanks!
As we don't implement customized built-in elements we have no need for the constructor I think. Fixing the onerror member makes sense to me.
There is patch already from Alexey on other bug with all tests passing but never landed. *** This bug has been marked as a duplicate of bug 234568 ***
(In reply to Ahmad Saleem from comment #2) > There is patch already from Alexey on other bug with all tests passing but > never landed. > > *** This bug has been marked as a duplicate of bug 234568 *** Wow huge thank you Ahmad for tracking this down and bringing to our attention, I will make sure to land https://bugs.webkit.org/show_bug.cgi?id=234568 over the weekend (I just need to put up a good ChangeLog based on my & Darin's comments).