WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
256496
AX: Fix various ITM tests after
263832@main
https://bugs.webkit.org/show_bug.cgi?id=256496
Summary
AX: Fix various ITM tests after 263832@main
Tyler Wilcock
Reported
2023-05-08 15:55:46 PDT
263832@main
changed the timing of AX object cache updates that some of our tests implicitly relied on. These tests need to be made properly async to be immune to timing changes. This change also exposes bugs where we dereference a null AXObjectCache assuming it will always be present -- we cannot make those assumptions in some contexts anymore.
Attachments
Patch
(24.46 KB, patch)
2023-05-08 16:00 PDT
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Patch
(25.46 KB, patch)
2023-05-08 17:56 PDT
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-05-08 15:56:01 PDT
<
rdar://problem/109063886
>
Tyler Wilcock
Comment 2
2023-05-08 16:00:52 PDT
Created
attachment 466289
[details]
Patch
Tyler Wilcock
Comment 3
2023-05-08 17:56:16 PDT
Created
attachment 466291
[details]
Patch
EWS
Comment 4
2023-05-09 00:01:59 PDT
Committed
263854@main
(d57954fad0e9): <
https://commits.webkit.org/263854@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 466291
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug