Bug 256518 - [CMake] Changing files listed in gi-docgen's TOML configuration does not rebuild documentation
Summary: [CMake] Changing files listed in gi-docgen's TOML configuration does not rebu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-09 02:43 PDT by Adrian Perez
Modified: 2023-05-09 06:40 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2023-05-09 02:43:34 PDT 
Editing urlmap.js or one of the .md files references from the TOML
configuration passed to gi-docgen should cause a rebuild, but currently
does not.
Comment 1 Adrian Perez 2023-05-09 02:44:46 PDT 
We can use “gi-docgen gen-deps” to generate a file that we can then
pass as DEPFILE in CMake, so Make/Ninja will read the file to learn
about the dependencies which aren't listed in CMake.
Comment 2 Adrian Perez 2023-05-09 06:02:40 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13636
Comment 3 Adrian Perez 2023-05-09 06:15:03 PDT 
There's a small issue in upstream gi-docgen, but not a blocker to
land the PR for this in WebKit:

  https://gitlab.gnome.org/GNOME/gi-docgen/-/issues/158
Comment 4 EWS 2023-05-09 06:39:15 PDT 
Committed 263862@main (9e4a1ee88a13): <https://commits.webkit.org/263862@main>

Reviewed commits have been landed. Closing PR #13636 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2023-05-09 06:40:21 PDT 
<rdar://problem/109093244>