RESOLVED FIXED256518
[CMake] Changing files listed in gi-docgen's TOML configuration does not rebuild documentation 
https://bugs.webkit.org/show_bug.cgi?id=256518
Summary [CMake] Changing files listed in gi-docgen's TOML configuration does not rebu...
Adrian Perez
Reported 2023-05-09 02:43:34 PDT
Editing urlmap.js or one of the .md files references from the TOML configuration passed to gi-docgen should cause a rebuild, but currently does not.
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2023-05-09 02:44:46 PDT
We can use “gi-docgen gen-deps” to generate a file that we can then pass as DEPFILE in CMake, so Make/Ninja will read the file to learn about the dependencies which aren't listed in CMake.
Adrian Perez
Comment 2 2023-05-09 06:02:40 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13636
Adrian Perez
Comment 3 2023-05-09 06:15:03 PDT
There's a small issue in upstream gi-docgen, but not a blocker to land the PR for this in WebKit: https://gitlab.gnome.org/GNOME/gi-docgen/-/issues/158
EWS
Comment 4 2023-05-09 06:39:15 PDT
Committed 263862@main (9e4a1ee88a13): <https://commits.webkit.org/263862@main> Reviewed commits have been landed. Closing PR #13636 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2023-05-09 06:40:21 PDT
<rdar://problem/109093244>
Note You need to log in before you can comment on or make changes to this bug.