Bug 256521 - git webkit pr gives useless error message when GitHub is down
Summary: git webkit pr gives useless error message when GitHub is down
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-09 05:40 PDT by Anne van Kesteren
Modified: 2023-05-16 05:41 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2023-05-09 05:40:34 PDT
GitHub was partially down today. This however made me think something was wrong with my checkout:

git webkit pr
branch 'main' set up to track 'origin/main'.
From https://github.com/WebKit/WebKit
 * branch                      main       -> FETCH_HEAD
Current branch eng/Synchronize-websockets-WPT is up to date.
    Found 1 commit...
Total errors found: 0 in 153 files
Traceback (most recent call last):
  File "/Users/annevk/Dev/Internal/Tools/Scripts/git-webkit", line 212, in <module>
    sys.exit(filtered_call(
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/filtered_call.py", line 37, in filtered_call
    return function(*args, **filtered_kwargs)
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 182, in main
    return parsed.main(
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 713, in main
    return cls.create_pull_request(repository, args, branch_point)
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py", line 564, in create_pull_request
    did_update_branch = fork_remote.request(
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 438, in request
    message = response.json().get('message') if is_json_response else ''
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/libraries/autoinstalled/python-3-arm64/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/opt/homebrew/Cellar/python@3.10/3.10.6_2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/opt/homebrew/Cellar/python@3.10/3.10.6_2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/opt/homebrew/Cellar/python@3.10/3.10.6_2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Comment 1 Radar WebKit Bug Importer 2023-05-16 05:41:18 PDT
<rdar://problem/109401042>