Bug 256525 - Clamp frameset cols/rows values safely to integers for absolute & percentage
Summary: Clamp frameset cols/rows values safely to integers for absolute & percentage
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-05-09 08:48 PDT by Ahmad Saleem
Modified: 2023-07-19 13:34 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-05-09 08:48:47 PDT 
Hi Team,

While looking at 'frameset' failure, I came across another Blink commit, which can lead to passes on WPT:

Failing WPT Tests: https://wpt.fyi/results/html/rendering/non-replaced-elements/the-frameset-and-frame-elements?label=master&label=experimental&aligned=&q=frameset

large-cols-abssize.html 
large-cols-percentage.html 
large-cols-relsize.html 
large-rows-abssize.html 
large-rows-percentage.html 
large-rows-relsize.html

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/7091ff7be362763203b68fb09f48898258df0c37

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFrameSet.cpp#186

Just wanted to raise, so this can be fixed. I tried locally to do clampTo<int> but these tests still fail, so it might be not my expertise area.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-05-16 08:49:25 PDT 
<rdar://problem/109407606>
Comment 2 Ahmad Saleem 2023-07-19 13:34:03 PDT 
For some reason, it does not lead to progressions on GTK-WK2 and WPE-WK2. I am closing my PR.

PR - https://github.com/WebKit/WebKit/pull/13858

But anyone from GTK-WK2 team, who can help in investigating the failures?