Bug 256560 - [LibWebRTC] Consolidate export files and add testing exports
Summary: [LibWebRTC] Consolidate export files and add testing exports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-09 16:02 PDT by David Kilzer (:ddkilzer)
Modified: 2023-05-11 06:58 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-05-09 16:02:01 PDT 
Consolidate export files and add testing exports for the libwebrtc project.

This bug covers a few export-file-related issues:

1. Removes unused files:

Source/ThirdParty/libwebrtc/Configurations/libwebrtc2.exp
Source/ThirdParty/libwebrtc/Configurations/libwebrtc4.exp

2. Consolidates macOS, iOS and iOS Sim export files into a single file (since they all had the exact same list of symbols):

Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp
Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp
Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp

Changed to:

Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp

3. Introduces libwebrtc.testing.exp for exporting test symbols for Debug and Release builds.

Source/ThirdParty/libwebrtc/Configurations/libwebrtc.testing.exp

4. Adds a "Generate Export Files" build phase script in the Xcode project to merge the files as needed.
Comment 1 Radar WebKit Bug Importer 2023-05-09 16:02:25 PDT 
<rdar://problem/109122945>
Comment 2 David Kilzer (:ddkilzer) 2023-05-09 16:14:19 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13666
Comment 3 EWS 2023-05-11 06:58:38 PDT 
Committed 263962@main (161a1abe6d07): <https://commits.webkit.org/263962@main>

Reviewed commits have been landed. Closing PR #13666 and removing active labels.