Bug 256572 - HysteresisActivity::impulse() thrashes a timer
Summary: HysteresisActivity::impulse() thrashes a timer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-09 21:14 PDT by Simon Fraser (smfr)
Modified: 2023-05-10 21:27 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-05-09 21:14:46 PDT 
HysteresisActivity::impulse() is implemented as:

    void impulse()
    {
        if (!m_active) {
            start();
            stop();
        }
    }

which will always stop and restart the timer if called repeatedly.
Comment 1 Radar WebKit Bug Importer 2023-05-09 21:15:10 PDT 
<rdar://problem/109134335>
Comment 2 Simon Fraser (smfr) 2023-05-09 22:27:05 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13681
Comment 3 EWS 2023-05-10 21:27:24 PDT 
Committed 263946@main (c408a82764d2): <https://commits.webkit.org/263946@main>

Reviewed commits have been landed. Closing PR #13681 and removing active labels.