Bug 256598 - AX: Cache relative frame for ScrollView and WebArea during page load in the IsolatedObject.
Summary: AX: Cache relative frame for ScrollView and WebArea during page load in the I...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-10 11:25 PDT by Andres Gonzalez
Modified: 2023-05-10 16:46 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2023-05-10 11:34 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2023-05-10 11:25:27 PDT 
Not doing so causes a hit on the main thread while busy building the isolated tree.
Comment 1 Radar WebKit Bug Importer 2023-05-10 11:25:40 PDT 
<rdar://problem/109162963>
Comment 2 Andres Gonzalez 2023-05-10 11:34:02 PDT 
Created attachment 466308 [details]
Patch
Comment 3 Tyler Wilcock 2023-05-10 11:45:07 PDT 
Comment on attachment 466308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466308&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:177
> +        setProperty(AXPropertyName::RelativeFrame, IntRect { object.relativeFrame() });

We use `enclosingIntRect(...)` when caching the paint rects, so let's use that over IntRect { ... } here too.
Comment 4 EWS 2023-05-10 16:46:09 PDT 
Committed 263938@main (a10c2f6a130d): <https://commits.webkit.org/263938@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466308 [details].