Bug 256621 - Mask back to front buffer copy when using remote rendering path
Summary: Mask back to front buffer copy when using remote rendering path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-10 16:52 PDT by Ben Nham
Modified: 2023-05-11 18:11 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2023-05-10 16:52:37 PDT 
When comparing QuartzCore's implementation of back to front buffer copies to our implementation of the copy in RemoteLayerBackingStore, there are two optimizations that we are missing. First, QuartzCore masks the back to front buffer copy by the dirty shape. Secondly, it avoids re-clearing a surface that was just allocated. Implement these optimizations in RemoteLayerBackingStore to see if they improve our memory bandwidth regression.
Comment 1 Radar WebKit Bug Importer 2023-05-10 16:52:56 PDT 
<rdar://problem/109179068>
Comment 2 Ben Nham 2023-05-10 16:57:06 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13729
Comment 3 Matt Woodrow 2023-05-11 13:59:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13770
Comment 4 EWS 2023-05-11 18:11:55 PDT 
Committed 263994@main (c26d9ad7d08d): <https://commits.webkit.org/263994@main>

Reviewed commits have been landed. Closing PR #13770 and removing active labels.