Bug 256624 - [UI-side compositing] Eliminate unnecessary invalidate of scrollbar layers when scrolling
Summary: [UI-side compositing] Eliminate unnecessary invalidate of scrollbar layers wh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Mouchtaris
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-10 19:18 PDT by Simon Fraser (smfr)
Modified: 2023-05-15 17:46 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-05-10 19:18:39 PDT 
Traces show that that we mark the scrollbar layers as needing repaint, and hit GraphicsLayerCA::platformCALayerPaintContents() for them, on every scroll.

If these are layers for native scrollbars, we don't paint them in the web process at all (the NSScrollerImps only live in the UI Process), so we shouldn't need to dirty the scrollbar layers.
Comment 1 Radar WebKit Bug Importer 2023-05-10 19:19:07 PDT 
<rdar://problem/109184266>
Comment 2 Nikos Mouchtaris 2023-05-12 17:39:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13840
Comment 3 EWS 2023-05-15 17:46:15 PDT 
Committed 264094@main (d19192443a84): <https://commits.webkit.org/264094@main>

Reviewed commits have been landed. Closing PR #13840 and removing active labels.