WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
256679
[WPE][GTK][CMake] The path to bwrap and xdg-dbus-proxy should not be auto-detected when cross-compiling
https://bugs.webkit.org/show_bug.cgi?id=256679
Summary
[WPE][GTK][CMake] The path to bwrap and xdg-dbus-proxy should not be auto-det...
Carlos Alberto Lopez Perez
Reported
2023-05-11 17:35:28 PDT
When enabling -DENABLE_BUBBLEWRAP_SANDBOX=ON is needed to defined to the build the paths (full-paths) to the bwrap and xdg-dbus-proxy binaries. The current CMake code is auto-detecting those paths by calling CMake function find_program(), so it is defining the paths to those programs with the values from the host system. But when cross-compiling that is wrong because the target binaries end with the values for the paths from the host system which don't necessary have to match the values from the target system. Those value may match if the distro of the host and the target is the same (for example cross-compiling on debian x86_64 for debian aarch64). But in other case don't match (for example cross-compiling in Debian for Yocto) I can't see how it will be possible to auto-detect the value that this programs will have in the target system, so the only sane way of dealing with this seems to be to give an error at configure time and ask for those paths to be defined manually.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2023-05-11 17:53:01 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/13787
EWS
Comment 2
2023-05-19 04:16:01 PDT
Committed
264244@main
(a84036c6d1d6): <
https://commits.webkit.org/264244@main
> Reviewed commits have been landed. Closing PR #13787 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug