Bug 256686 - Incorrect CORS mode for ApplicationManifest
Summary: Incorrect CORS mode for ApplicationManifest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Safari 16
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcos Caceres
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-11 22:58 PDT by Marcos Caceres
Modified: 2023-07-31 11:00 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Caceres 2023-05-11 22:58:36 PDT 
In the HTML spec:
https://html.spec.whatwg.org/#link-type-manifest

The linked resource fetch setup steps for this type of linked resource, given a link element el and request request, are:
…
6. Set request's mode to "cors".
7. Set request's credentials mode to the CORS settings attribute credentials mode for el's crossorigin content attribute.

However, WebKit is loading ApplicationManifest with no cors.
Comment 1 Marcos Caceres 2023-05-11 22:59:28 PDT 
<rdar://problem/109154572>
Comment 2 Marcos Caceres 2023-05-11 23:05:08 PDT 
Pull request: https://github.com/apple/WebKit/pull/594
Comment 3 EWS 2023-06-09 02:18:30 PDT 
Committed 259548.816@safari-7615-branch (8437c2302b67): <https://commits.webkit.org/259548.816@safari-7615-branch>

Reviewed commits have been landed. Closing PR #594 and removing active labels.
Comment 4 EWS 2023-07-31 11:00:11 PDT 
merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label