Bug 256701 - Fragment blocks with non-visible overflow as normally when printing
Summary: Fragment blocks with non-visible overflow as normally when printing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-12 06:48 PDT by Ahmad Saleem
Modified: 2023-05-14 06:53 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-05-12 06:48:25 PDT
Hi Team,

While going through Blink's commit, I came across another potential merge to fix 'printing' issue.

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/054e1dec56f7a7a76f64adc9b3a27c94d0778e33

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#5218

Test Case still exist on Blink's source tree.

_______

Spec reference:

The spec https://drafts.csswg.org/css-break/#possible-breaks currently says:

"Some content is not fragmentable, for example many types of replaced elements [CSS21] (such as images or video), scrollable elements, or a single line of text content. Such content is considered monolithic: it contains no possible break points. Any forced breaks within such boxes therefore cannot split the box, and must therefore also be ignored by the box’s own fragmentation context.

______

Behavior is not direct violation of spec but was choice to align Blink with other browser engines except WebKit.

_________

Appreciate if someone can share input and if needed, we can merge this new behavior.

Thanks!
Comment 1 zalan 2023-05-12 21:14:23 PDT
seems like a good merge.
Comment 2 EWS 2023-05-14 06:52:27 PDT
Committed 264059@main (73de3248842c): <https://commits.webkit.org/264059@main>

Reviewed commits have been landed. Closing PR #13854 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-05-14 06:53:20 PDT
<rdar://problem/109320964>