Bug 256759 - [GPU Process][Filters] Implement equality operator for FilterEffect
Summary: [GPU Process][Filters] Implement equality operator for FilterEffect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-13 07:11 PDT by Said Abou-Hallawa
Modified: 2023-05-13 12:20 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-05-13 07:11:35 PDT 
This will be needed when caching the FilterResults in GPUProcess. We need to identify the modified FilterEffects so we can clear their FilterImages. They will be regenerated when the filtered ImageBuffer is displayed.

The FilterEffect::operator==() will be virtual and will be overridden by all the superclasses. All the properties of the superclass and the properties of FilterEffect will be compared for equality.
Comment 1 Radar WebKit Bug Importer 2023-05-13 07:11:55 PDT 
<rdar://problem/109303025>
Comment 2 Said Abou-Hallawa 2023-05-13 07:22:29 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13856
Comment 3 EWS 2023-05-13 12:20:41 PDT 
Committed 264050@main (5f6cc633dcd4): <https://commits.webkit.org/264050@main>

Reviewed commits have been landed. Closing PR #13856 and removing active labels.