Bug 256775 - [baseline-alignment] Move general baseline alignment code out of GridBaselineAlignment
Summary: [baseline-alignment] Move general baseline alignment code out of GridBaseline...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-14 22:01 PDT by Sammy Gill
Modified: 2023-05-16 07:27 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-05-14 22:01:44 PDT 
GridBaselineAlignment.cpp has code that is general to baseline alignment (BaselineContext and BaselineGroup) that is not specific to grid. We can separate these two classes out and use them in other formatting context like flex
Comment 1 Radar WebKit Bug Importer 2023-05-14 22:02:11 PDT 
<rdar://problem/109336789>
Comment 2 Sammy Gill 2023-05-14 22:12:16 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13868
Comment 3 EWS 2023-05-16 07:27:52 PDT 
Committed 264113@main (493db53c8c0b): <https://commits.webkit.org/264113@main>

Reviewed commits have been landed. Closing PR #13868 and removing active labels.