Bug 256793 - [interop23][css-flexbox][baseline-aligment] Add flex items to a BaselineContext
Summary: [interop23][css-flexbox][baseline-aligment] Add flex items to a BaselineContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks: 256947
  Show dependency tree / graph
 
Reported: 2023-05-15 11:14 PDT by Sammy Gill
Modified: 2023-07-28 09:53 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-05-15 11:14:53 PDT 
BaselineContext holds multiple BaselineGroups and we should use that so the flex items are placed into the correct baseline sharing group. After that, we can perform the rest of the steps as described in the spec below

https://drafts.csswg.org/css-align-3/#baseline-rules
Comment 1 Radar WebKit Bug Importer 2023-05-15 11:15:26 PDT 
<rdar://problem/109362699>
Comment 2 Sammy Gill 2023-05-17 10:17:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13968
Comment 3 EWS 2023-07-28 09:53:46 PDT 
Committed 266387@main (b7b43b9bf044): <https://commits.webkit.org/266387@main>

Reviewed commits have been landed. Closing PR #13968 and removing active labels.