Bug 256795 - BaselineContext m_items should not hold raw pointers
Summary: BaselineContext m_items should not hold raw pointers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-15 11:35 PDT by Sammy Gill
Modified: 2023-05-16 17:53 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-05-15 11:35:19 PDT 
Instead of raw pointer's to the renderers we should use something else like a WeakPtr
Comment 1 Radar WebKit Bug Importer 2023-05-15 11:35:46 PDT 
<rdar://problem/109363884>
Comment 2 zalan 2023-05-15 11:36:17 PDT 
(In reply to Sammy Gill from comment #0)
> Instead of raw pointer's to the renderers we should use something else like
> a WeakPtr
Preferably CheckedPtr.
Comment 3 Sammy Gill 2023-05-16 13:29:06 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13935
Comment 4 EWS 2023-05-16 17:53:01 PDT 
Committed 264132@main (62aba919edb6): <https://commits.webkit.org/264132@main>

Reviewed commits have been landed. Closing PR #13935 and removing active labels.