Bug 256828 - Notifications API: default silent to platform convention
Summary: Notifications API: default silent to platform convention
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcos Caceres
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-15 23:33 PDT by Marcos Caceres
Modified: 2023-05-22 20:12 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Caceres 2023-05-15 23:33:39 PDT 
The NotificationOptions dictionary specifies boolean silent=false; by default.

That default can conflict with certain platforms/OSs, whereby if a notification is silent (or not) should really be left up to OS.

Spec change:
https://github.com/whatwg/notifications/pull/194

The proposal makes the silent member on the NotificationOption dictionary default to null. This is then reflected by the silent attribute of the Notification interface.
Comment 1 Radar WebKit Bug Importer 2023-05-15 23:34:37 PDT 
<rdar://problem/109390045>
Comment 2 Marcos Caceres 2023-05-15 23:36:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13912
Comment 3 EWS 2023-05-22 20:12:28 PDT 
Committed 264397@main (bb5a5fbce2e9): <https://commits.webkit.org/264397@main>

Reviewed commits have been landed. Closing PR #13912 and removing active labels.