Bug 256912 - [GLib] Remove obsolete documentation from WebKitWebsiteDataManager
Summary: [GLib] Remove obsolete documentation from WebKitWebsiteDataManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-17 12:06 PDT by Michael Catanzaro
Modified: 2023-05-18 06:03 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-05-17 12:06:44 PDT 
The WebKitWebsiteDataManager documentation has many references to WebKitWebContext ownership of WebKitWebsiteDataManager, but in the 2022 API version it is owned by WebKitNetworkSession. It's hard to fix because we cannot use conditional compilation inside doc comments. We can either (a) move the doc comment to the header file and have two different copies of the comment, or (b) simplify the comment by removing info about behavior that varies between API versions. I've opted for (b). I think most developers should still be able to figure out how to use it... hopefully.
Comment 1 Michael Catanzaro 2023-05-17 12:10:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13979
Comment 2 EWS 2023-05-18 06:03:20 PDT 
Committed 264198@main (429ffbd25b0e): <https://commits.webkit.org/264198@main>

Reviewed commits have been landed. Closing PR #13979 and removing active labels.