Bug 256931 - [webkitcorepy] Fix race condition in FileLock
Summary: [webkitcorepy] Fix race condition in FileLock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-17 17:15 PDT by Jonathan Bedard
Modified: 2023-05-22 07:40 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-05-17 17:15:41 PDT 
If a process releases and then imiediately attempts to re-aquire a FileLock, we will end up with a race-condition if another process is also trying to do the same. FileLock should be robust against this race condition, since this is precisely the situation where a FileLock is most useful.
Comment 1 Radar WebKit Bug Importer 2023-05-17 17:16:19 PDT 
<rdar://problem/109487762>
Comment 2 Jonathan Bedard 2023-05-17 17:19:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13993
Comment 3 EWS 2023-05-22 07:40:06 PDT 
Committed 264321@main (1c10cac85558): <https://commits.webkit.org/264321@main>

Reviewed commits have been landed. Closing PR #13993 and removing active labels.