Bug 256937 - [css-flexbox][baseline-alignment] Flex item's with different writing mode from flex container should not always synthesize a baseline
Summary: [css-flexbox][baseline-alignment] Flex item's with different writing mode fro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
: 247640 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-05-17 17:53 PDT by Sammy Gill
Modified: 2023-12-20 14:50 PST (History)
4 users (show)

See Also:


Attachments
Testcase (710 bytes, text/html)
2023-05-17 17:53 PDT, Sammy Gill
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-05-17 17:53:09 PDT
Created attachment 466390 [details]
Testcase

Flex layout will call into a flex item's firstLineBaseline/lastLineBaseline in order to compute an ascent for the item to use in baseline alignment. If the flex item has a different writing mode from the flex container then it will return std::nullopt because of the check for isWritingModeRoot() and as a result will have a baseline synthesized. In the attached test case (reduced from css-flexbox/alignment/flex-align-baseline-001.html) we should still be able to compute baseline values for the flex items since the block axis for the items is parallel to the alignment context.
Comment 1 Radar WebKit Bug Importer 2023-05-17 17:53:32 PDT
<rdar://problem/109489182>
Comment 2 Sammy Gill 2023-05-19 15:38:02 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14108
Comment 3 Sammy Gill 2023-05-22 21:50:09 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/40153
Comment 4 EWS 2023-05-23 10:18:58 PDT
Committed 264423@main (2c62617577b6): <https://commits.webkit.org/264423@main>

Reviewed commits have been landed. Closing PR #14108 and removing active labels.
Comment 5 Sammy Gill 2023-12-20 14:50:08 PST
*** Bug 247640 has been marked as a duplicate of this bug. ***