Bug 256953 - XPath: Fix context node after evaluating an expression in a predicate
Summary: XPath: Fix context node after evaluating an expression in a predicate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-05-18 01:02 PDT by Ahmad Saleem
Modified: 2023-05-18 13:47 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-05-18 01:02:43 PDT 
Hi Team,

This is another potential merge to fix bug in DOMXPath and fix all uniquely failing tests in WebKit / Safari.

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/869417867e1da3822a03f8ce1e454d19706c6832

WPT Link - https://wpt.fyi/results/domxpath/predicates.html?label=experimental&label=master&aligned=

Direct Test Link - http://wpt.live/domxpath/predicates.html

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/xml/XPathPredicate.cpp#284

Just wanted to raise, so we can fix this last unique one as well.

Thanks!
Comment 1 Chris Dumez 2023-05-18 11:29:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14026
Comment 2 EWS 2023-05-18 13:46:23 PDT 
Committed 264210@main (1ffefa8e2da2): <https://commits.webkit.org/264210@main>

Reviewed commits have been landed. Closing PR #14026 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-05-18 13:47:25 PDT 
<rdar://problem/109530225>