Bug 256981 - [git-webkit] Keywords can contains colons
Summary: [git-webkit] Keywords can contains colons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-18 13:53 PDT by Jonathan Bedard
Modified: 2023-05-19 08:10 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-05-18 13:53:04 PDT 
Our original keyword regexes assumed that keywords could not contain colons. This assumption is incorrect.
Comment 1 Radar WebKit Bug Importer 2023-05-18 13:53:33 PDT 
<rdar://problem/109530553>
Comment 2 Jonathan Bedard 2023-05-18 13:55:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14030
Comment 3 EWS 2023-05-19 08:10:24 PDT 
Committed 264257@main (d94a32bf5638): <https://commits.webkit.org/264257@main>

Reviewed commits have been landed. Closing PR #14030 and removing active labels.