Bug 256998 - [Website] payment-request demo backend has a syntax error
Summary: [Website] payment-request demo backend has a syntax error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac (Apple Silicon) macOS 13
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-18 17:45 PDT by Alex Zenla
Modified: 2023-05-22 14:22 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Zenla 2023-05-18 17:45:31 PDT 
Upon doing other things in WebKit, I noticed a syntax error in the backend code for the payment-request demo.

if (!$result = curl_exec($curlConnection))
    die('An error occurred when connecting to the validation URL.'));

Running this code (note, I recognize this is a web PHP file, yet this will check the syntax) provides this error.


alex@sodium WebKit % php Websites/webkit.org/demos/payment-request/merchant-validation.php
PHP Parse error:  Unmatched ')' in /Users/alex/Developer/Web/WebKit/Websites/webkit.org/demos/payment-request/merchant-validation.php on line 94

Parse error: Unmatched ')' in /Users/alex/Developer/Web/WebKit/Websites/webkit.org/demos/payment-request/merchant-validation.php on line 94
Comment 1 Alex Zenla 2023-05-18 17:52:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14048
Comment 2 EWS 2023-05-22 14:21:06 PDT 
Committed 264378@main (365d91ad2c52): <https://commits.webkit.org/264378@main>

Reviewed commits have been landed. Closing PR #14048 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-05-22 14:22:17 PDT 
<rdar://problem/109677760>