Bug 257004 - RemoteLayerTreeDisplayRefreshMonitor::requestRefreshCallback doesn't clear scheduled state
Summary: RemoteLayerTreeDisplayRefreshMonitor::requestRefreshCallback doesn't clear sc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-18 18:45 PDT by Matt Woodrow
Modified: 2023-05-20 18:40 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-05-18 18:45:11 PDT 
RemoteLayerTreeDisplayRefreshMonitor::requestRefreshCallback dispatches a task to the main thread and sets scheduled to true.

When that task runs, it triggers the rendering update but doesn't set scheduled back to false.

Normally, the rendering update results in a commit to the UI process, and then we get a RemoteLayerTreeDrawingArea::displayDidRefresh callback, which sets scheduled to false (but also triggers a second rendering update).
Comment 1 Matt Woodrow 2023-05-18 18:45:43 PDT 
<rdar://107848069>
Comment 2 Matt Woodrow 2023-05-18 18:50:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14052
Comment 3 EWS 2023-05-20 18:40:10 PDT 
Committed 264297@main (f0847a50740a): <https://commits.webkit.org/264297@main>

Reviewed commits have been landed. Closing PR #14052 and removing active labels.