Bug 257009 - import-w3c-tests throws when specifying --clean-dest-dir
Summary: import-w3c-tests throws when specifying --clean-dest-dir
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-19 00:09 PDT by Anne van Kesteren
Modified: 2023-05-22 16:21 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2023-05-19 00:09:44 PDT 
% import-w3c-tests web-platform-tests/html/semantics/forms/constraints --clean-dest-dir -l -s ../../Documents/GitHub.nosync
Traceback (most recent call last):
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/import-w3c-tests", line 35, in <module>
    sys.exit(test_importer.main(sys.argv[1:], sys.stdout, sys.stderr))
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 95, in main
    test_importer = TestImporter(Host(), test_paths, options)
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 189, in __init__
    self.remove_slow_from_w3c_tests_options()
  File "/Users/annevk/Dev/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 651, in remove_slow_from_w3c_tests_options
    for test_path in self._tests_options.keys():
RuntimeError: dictionary changed size during iteration
Comment 1 Sam Sneddon [:gsnedders] 2023-05-19 07:10:00 PDT 
I fixed this in https://github.com/WebKit/WebKit/pull/13929 (which is bug 256751), as part of writing the tests that Youenn had asked for previously. Keeping this open until that lands.
Comment 2 Sam Sneddon [:gsnedders] 2023-05-22 16:20:07 PDT 
Okay, this should be fixed in 264384@main (348235605fd9): <https://commits.webkit.org/264384@main>
Comment 3 Radar WebKit Bug Importer 2023-05-22 16:21:17 PDT 
<rdar://problem/109685069>