Bug 257018 - webkitscmpy.program.pull_request should tell check-webkit-style the branch point
Summary: webkitscmpy.program.pull_request should tell check-webkit-style the branch point
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-19 03:28 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-05-19 03:28 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-05-19 03:28:41 PDT 
Currently running `git-webkit pr` calls `check-webkit-style` by default.

However, both commands run `Branch.branch_point` for the commit being pushed, and `Branch.branch_point` is famously slow (e.g., bug 256855).

Instead of spending ~15s doing this twice, we should spend ~7.5s doing it once, and `git-webkit pr` should simply tell `check-webkit-style` what commit to use as the branch point.
Comment 1 Radar WebKit Bug Importer 2023-05-19 03:28:56 PDT 
<rdar://problem/109558732>