Bug 257019 - [Cairo] Unnecessary overrides `GraphicsContext::drawGlyphs()` and `GraphicsContext::drawDecomposedGlyphs()`
Summary: [Cairo] Unnecessary overrides `GraphicsContext::drawGlyphs()` and `GraphicsCo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-19 04:31 PDT by Vitaly Dyackhov
Modified: 2023-05-19 08:16 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Dyackhov 2023-05-19 04:31:45 PDT 
Default `GraphicsContext::drawGlyphs()` simply calls `FontCascade::drawGlyphs()` but `GraphicsContextCairo::drawGlyphs()` duplicates the logic of `FontCascade::drawGlyphs()`.
`GraphicsContextCairo::drawDecomposedGlyphs()` is virtually the same as `GraphicsContext::drawDecomposedGlyphs()`.
Comment 1 Vitaly Dyackhov 2023-05-19 04:37:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14068
Comment 2 EWS 2023-05-19 08:16:50 PDT 
Committed 264258@main (0aad38b2c526): <https://commits.webkit.org/264258@main>

Reviewed commits have been landed. Closing PR #14068 and removing active labels.