Bug 257029 - Refuse to paginate if page height is 0.
Summary: Refuse to paginate if page height is 0.
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-19 06:51 PDT by Ahmad Saleem
Modified: 2023-06-18 06:35 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-05-19 06:51:26 PDT 
Hi Team,

While going through Blink's commit, I came across another potential printing related fix:

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/57d2e8b50df8fdef54079ef97960491a4868d0cc

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderView.cpp#192

Just wanted to raise to get input, if it is good fix, if yes, I can try to do PR.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-05-26 06:52:15 PDT 
<rdar://problem/109886929>
Comment 2 Ahmad Saleem 2023-06-18 06:35:25 PDT 
It is not needed, just read the code again and it is nested so don’t need.

We can merge tests though but I think we are fine either way.