Bug 257100 - [image-set] Pick first choice when identical resolutions are found
Summary: [image-set] Pick first choice when identical resolutions are found
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Reno
URL: https://wpt.fyi/results/css/css-image...
Keywords: BrowserCompat, InRadar, WPTImpact
: 257193 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-05-20 22:38 PDT by Tim Nguyen (:ntim)
Modified: 2023-05-24 18:38 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-05-20 22:38:50 PDT 
https://drafts.csswg.org/css-images-4/#image-set-notation

> Second, remove any <image-set-option>s from the list that have the same <resolution> as a previous option in the list.

This implies we need to pick first choice when identical resolutions are found.

WPT: https://wpt.fyi/results/css/css-images/image-set/image-set-type-first-match-rendering.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat
Comment 1 Radar WebKit Bug Importer 2023-05-20 22:39:11 PDT 
<rdar://problem/109619779>
Comment 2 Ryan Reno 2023-05-23 22:55:14 PDT 
*** Bug 257193 has been marked as a duplicate of this bug. ***
Comment 3 Ryan Reno 2023-05-23 23:27:33 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14285
Comment 4 EWS 2023-05-24 11:13:27 PDT 
Committed 264481@main (56e5d7cb43e7): <https://commits.webkit.org/264481@main>

Reviewed commits have been landed. Closing PR #14285 and removing active labels.