Bug 257114 - Fix break with MODERN_MEDIA_CONTROLS disabled after 264293@main
Summary: Fix break with MODERN_MEDIA_CONTROLS disabled after 264293@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-22 01:02 PDT by Yousuke Kimoto
Modified: 2023-05-22 11:32 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2023-05-22 01:02:20 PDT 
A build break happens with MODERN_MEDIA_CONTROLS disabled after 264293@main.

https://github.com/WebKit/WebKit/commit/0ee37c4333af683443d1934d4cbb137bfcc7cb26#diff-7ac4f7324d9124e084a5beb893df1cebec8aaf139685b7a8675eba3b35a942edR108-R119
>     enum class SourceType : uint8_t {
>        File,
>        HLS,
>        MediaSource,
>        ManagedMediaSource,
>        MediaStream,
>        LiveStream,
>        StoredStream,
>    };
>
>    std::optional<SourceType> sourceType() const;

These code should be blocked by "ENABLE(MODERN_MEDIA_CONTROLS)"
Comment 1 Yousuke Kimoto 2023-05-22 02:27:54 PDT 
WebCore/Modules/mediacontrols/MediaControlsHost.idl also needs to define "sourceType" with [Conditional=MODERN_MEDIA_CONTROLS].
Comment 2 Yousuke Kimoto 2023-05-22 02:30:26 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14173
Comment 3 EWS 2023-05-22 11:31:38 PDT 
Committed 264335@main (e76387590957): <https://commits.webkit.org/264335@main>

Reviewed commits have been landed. Closing PR #14173 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-05-22 11:32:24 PDT 
<rdar://problem/109669766>