Bug 257173 - MachSendRights can release their IOSurface use-counts before CA adds a new ones
Summary: MachSendRights can release their IOSurface use-counts before CA adds a new ones
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-22 17:23 PDT by Matt Woodrow
Modified: 2023-05-26 20:48 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-05-22 17:23:46 PDT 
CoreAnimation doesn't add a new use-count to CAIOSurfaces until the transaction is committed, which is after the MachSendRight (inside LayerTreeTransaction/RemoteLayerBackingStoreProperties) is destroyed.

We should run an explicit CATransaction for layer tree commits to ensure that we always have a use-count added.
Comment 1 Radar WebKit Bug Importer 2023-05-22 17:23:57 PDT 
<rdar://problem/109687766>
Comment 2 Matt Woodrow 2023-05-22 17:29:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14222
Comment 3 EWS 2023-05-26 20:48:32 PDT 
Committed 264617@main (a59adccf52b4): <https://commits.webkit.org/264617@main>

Reviewed commits have been landed. Closing PR #14222 and removing active labels.